Code review comment for lp:~soren/nova/execvp-fallout

Revision history for this message
Thierry Carrez (ttx) wrote :

Looks good, could you add this one to the mix ?

--- nova/network/linux_net.py 2011-03-09 20:33:20 +0000
+++ nova/network/linux_net.py 2011-03-10 14:14:07 +0000
@@ -216,7 +216,7 @@
         _execute('sudo', 'brctl', 'setfd', bridge, 0)
         # _execute("sudo brctl setageing %s 10" % bridge)
         _execute('sudo', 'brctl', 'stp', bridge, 'off')
- _execute('sudo', 'ip', 'link', 'set', bridge, up)
+ _execute('sudo', 'ip', 'link', 'set', bridge, 'up')
     if net_attrs:
         # NOTE(vish): The ip for dnsmasq has to be the first address on the
         # bridge for it to respond to reqests properly

« Back to merge proposal