Code review comment for lp:~soren/nova/avoid-zombie-chains

2011/3/11 Rick Harris <email address hidden>:
>> 10    +        if self.instances.pop(instance['id'], False):
> Since instance['id'] isn't a bool, the fallback should probably be None.

Fixed.

>> 15    -                       'filtered'), instance['id'])
>> 6     +                   'filtered'), instance['id'])
> Any reason to include this in the final patch?

Um, yes, but not like that :) I wanted to align it with the outer
paren, but somehow I managed to screw that up. Fixed.

--
Soren Hansen        | http://linux2go.dk/
Ubuntu Developer    | http://www.ubuntu.com/
OpenStack Developer | http://www.openstack.org/