Code review comment for lp:~sophron/postorius/create_users

Revision history for this message
Florian Fuchs (flo-fuchs) wrote :

Hi George,

thank you for your changes (and the bug reports)! I have just merged them to the trunk. I only made some very small changes and additions (adjusted the docstring in MailmanUserView, added the user icon, some PEP8 fixes...). I also made the user list and details only available to superusers (I don't think every user should be able to see who else is there...).

So now that we have a method to add new users to the core, we need a way to connect them to the users in the postorius database (the ones added through django.contrib.auth). I added some comment about that in the bug description:

https://bugs.launchpad.net/postorius/+bug/1058445

Cheers and thanks again
Florian

review: Approve

« Back to merge proposal