Merge lp:~sonia/ubuntu/quantal/vim-scripts/fix-for-31204 into lp:ubuntu/quantal/vim-scripts

[Sonia Hamilton]

Updated the description to give a better indication of what's included in the package. (LP: #31204).

This is my first merge proposal - feedback welcome.

[Scott Kitterman (kitterman)]

For changes inside the debian dir, you don't use a patch. Just make the change directly. Also you added exuberant-ctags, aspell, and ispell to Suggests, but don't mention it in debian/changelog (which should be a record of all changes and particularly why).

review: Needs Fixing

[lp:~sonia/ubuntu/quantal/vim-scripts/fix-for-31204]

14. By Sonia Hamilton on 2012-09-29

* Updated the description to give a better indication of what's included in
  the package. (LP: #31204)
* Appended exuberant-ctags, aspell, ispell to the Suggests field, as they
  would enhance the usefulness of some of the plugins. (LP: #31204)

[Dimitri John Ledkov (xnox)]

The description is much better now, indeed. Looking at the package, it seems that it has evolved since #31204 was filed. There are now git/bzr/hg plugins and a few others not mentioned. And maintaining this list is not automatic. I see that some plugins use the "File:" or "Help:" header to describe themselves. Maybe these can be automatically harvested and added to the description?

Anyway that is just a suggestion...

"Here is an abbreviated summary of the included scripts:"
should be changed to
"Here is an abbreviated summary of some of the included scripts:"

Or document the rest of them? =)

[lp:~sonia/ubuntu/quantal/vim-scripts/fix-for-31204]

15. By Sonia Hamilton on 2012-09-30

change wording of description

[Sonia Hamilton (sonia)]

Hi Dmitrijs,

Automatically maintaining the description would be difficult, as the tags used in the scripts are inconsistent. If you do a `egrep -r 'Help:|File' *` you'll see what I mean.

The git/bzr/hg plugins are covered by the inclusion of vcscommand.vim in the list of general plugins - it covers "cvs, svn, git, hg, bzr, svk".

[Sonia Hamilton (sonia)]

I notice that this is similar to Evolution Plugins http://packages.ubuntu.com/quantal/evolution-plugins.

Is there anything else I need to do to get this sponsored?

review: Resubmit (fixed 'needs fixing')

[Sonia Hamilton (sonia)]

@infinity on #ubuntu-devel said:

soniah: None of those changes look Ubuntu-specific in the least, have you
                  proposed the patch to the Debian maintainer?
soniah: He actually literally JUST did an upload to Debian, and he's on IRC
                  right now as jamessan.
soniah: We try to make sure all our (non-Ubuntu-specific) patches end up
                  pushed to Debian, so it really makes sense to just start there, IMO.
soniah: Makes sense doubly-so right now, since Ubuntu is in a freeze leading
                  up to a release, so uploading for cosmetic fixes seems less likely.

11:35 -!- jamessan [~jamessan@debian/developer/jamessan]
11:35 -!- ircname : James McCoy
11:35 -!- server : lindbohm.freenode.net [Stockholm, Sweden]
11:35 -!- away : stuff
11:35 -!- account : jamessan
11:35 -!- End of WHOIS
11:37 -!- * jamessan G 0 ~jamessan@debian/developer/jamessan [James McCoy]

[Serge Hallyn (serge-hallyn)]

@Sonia,

given your last comment, did you in fact talk to the Debian maintainer? You could also simply submit it as a debian bug and link it here. In either case, if you are going to go that route (which is encouraged) then the merge request can be closed as we'll get the fix through Debian.

[Sonia Hamilton (sonia)]

Hi Serge,

I've been busy at work. I contacted the Debian developer, and I'm going
to submit a patch to him.

Sonia.

On Sat, Oct 20, 2012, at 06:00, Serge Hallyn wrote:
> @Sonia,
>
> given your last comment, did you in fact talk to the Debian maintainer?
> You could also simply submit it as a debian bug and link it here. In
> either case, if you are going to go that route (which is encouraged) then
> the merge request can be closed as we'll get the fix through Debian.
> --
> https://code.launchpad.net/~sonia/ubuntu/quantal/vim-scripts/fix-for-31204/+merge/126966
> You are the owner of lp:~sonia/ubuntu/quantal/vim-scripts/fix-for-31204.

[Sonia Hamilton (sonia)]

I've emailed the patch to the debian maintainer (jamessan@) - I'll wait for his reply.

I'm not sure of the next step I should take on the Ubuntu side.

review: Resubmit

[Sebastien Bacher (seb128)]

did you get any news from the debian maintainer? is there any chance you could open a bug on the Debian BTS for public tracking? not sure we want a diff in Ubuntu for that since we are currently on sync with Debian for that source...

[Sonia Hamilton (sonia)]

My understanding is that a fix has been released, so no more work needs to be done on this bug.

=== modified file 'debian/changelog'
--- debian/changelog	2011-08-13 23:11:06 +0000
+++ debian/changelog	2012-09-30 11:13:21 +0000
@@ -1,3 +1,12 @@
+vim-scripts (20110813ubuntu1) UNRELEASED; urgency=low
+
+  * Updated the description to give a better indication of what's included in
+    the package. (LP: #31204)
+  * Appended exuberant-ctags, aspell, ispell to the Suggests field, as they
+    would enhance the usefulness of some of the plugins. (LP: #31204)
+
+ -- Sonia Hamilton <[e-mail]>  Fri, 28 Sep 2012 23:30:10 +1000
+
 vim-scripts (20110813) unstable; urgency=low
 
   * Rename "colors sampler pack" to "colors-sampler-pack" so it's easier to

=== modified file 'debian/control'
--- debian/control	2011-08-13 23:11:06 +0000
+++ debian/control	2012-09-30 11:13:21 +0000
@@ -14,7 +14,7 @@
 Architecture: all
 Depends: ${misc:Depends}
 Recommends: vim, vim-addon-manager
-Suggests: perlsgml, libtemplate-perl
+Suggests: perlsgml, libtemplate-perl, exuberant-ctags, aspell, ispell
 Enhances: vim
 Description: plugins for vim, adding bells and whistles
  Vim is a very capable editor. Its scripting support allows the use of plugins
@@ -24,4 +24,41 @@
  .
  This is a collection of some of those scripts on a purely subjective and biased
  basis.  Users can thus have some nice scripts without having to go searching.
- The scripts can be installed globally or on a per user basis.
+ The scripts can be installed globally or on a per user basis. Here is an
+ abbreviated summary of some of the included scripts:
+ .
+ Filetype Plugins
+     * po.vim - Easier editing of PO multi-lingual translation files
+     * xml.vim - Helper for editing XML, HTML, and SGML documents
+ .
+ Games
+     * VimSokoban_sokoban.vim - Sokoban Game for Vim
+     * tetris.vim - Tetris for Vim
+ .
+ General Plugins
+     * Align.vim - Provides commands to help produce aligned text, eqns, declarations
+     * EnhancedCommentify.vim - Quickly comment lines in a program
+     * NERD_commenter.vim - easy code commenting
+     * a.vim - Alternate Files quickly (.c --> .h etc)
+     * bufexplorer.vim - Easily switch between buffers without knowing their numbers
+     * calendar.vim - Calendar
+     * cvscommand.vim - CVS integration plugin
+     * cvsmenu.vim - CVS menu supporting most CVS commands
+     * gnupg.vim - Transparent editing of gpg encrypted files
+     * info.vim - GNU info documentation browser
+     * minibufexpl.vim - Elegant buffer explorer - takes very little screen space
+     * svncommand.vim - Subversion (svn) integration plugin
+     * taglist.vim - Source code browser (supports dozens of langauges)
+     * themes.vim - All the color schemes on vim.sf.net, with menu
+     * utl.vim - Univeral Text Linking - Execute URLs in plain text
+     * vcscommand.vim - Commands for cvs, svn, git, hg, bzr, svk
+     * vimspell.vim - ispell or aspell based spell checker with fly-spelling
+     * whatdomain.vim - Find out the meaning of any Top Level Domain
+     * winmanager.vim - A windows style IDE for Vim 6.0
+ .
+ Colors
+     * over 100 different color schemes e.g. autumn.vim, eclipse.vim, navajo.vim
+ .
+ Syntax Files
+     * CVSAnnotate.vim, gitAnnotate.vim, .. - for version control files
+     * deb.vim - for browsing debian packages