Code review comment for lp:~songofacandy/qbzr/qbrowse-fix

Revision history for this message
Alexander Belchenko (bialix) wrote :

Gary van der Merwe пишет:
> On 06/01/2010 12:18, Alexander Belchenko wrote:
>> Why you're using posixpath module instead of bzrlib.osutils.pathjoin
>> function? I think the right way is to use the latter function. Do you
>> have any specific reasons to avoid it?
>
> I questioned that when I reviewed this. In this case, we need '/', even
> on windows. This is to fix bug 495519.

Gary, osutils.pathjoin *forces* '/' on Windows. That's why I've asked
about it.

« Back to merge proposal