+ if old_env is not None:
+ os.envirion['BZR_USER_ENCODING'] = old_env
should be os.environ.
But I think bzrlib.osutils already has special method to set/unset
environment variables, and in the tests you should use it instead of
manual manipulations.
INADA Naoki пишет: /code.launchpad .net/~songofaca ndy/bzr/ user_encoding_ utf8/+merge/ 90039 get_user_ encoding( ) fallbacks to utf8 instead of ascii.
> INADA Naoki has proposed merging lp:~songofacandy/bzr/user_encoding_utf8 into lp:bzr/2.5.
>
> Requested reviews:
> bzr-core (bzr-core)
>
> For more details, see:
> https:/
>
> * osutils.
> * Add BZR_USER_ENCODING envvar to override user encoding.
The latter sounds great!
I've spotted small typo in your patch though:
+ if old_env is not None: 'BZR_USER_ ENCODING' ] = old_env
+ os.envirion[
should be os.environ.
But I think bzrlib.osutils already has special method to set/unset
environment variables, and in the tests you should use it instead of
manual manipulations.
--
All the dude wanted was his rug back