Code review comment for lp:~songofacandy/bzr/i18n

Revision history for this message
Alexander Belchenko (bialix) wrote :

INADA Naoki пишет:
> = About license and copyright. =
>> - you seem to import code from the qbzr project, I think our policy to put these kind of files under bzrlib/util, not bzrlib/extras (I'd also like a second opinion about whether this kind of copy is appropriate, IANAL, etc),
>
> extras/ directory (not in bzrlib/ directory) contains files only for building pot file.
> I think 'tools/' directory is contains 3rd party tools that is required while building.
> So I'll move extras/* into tools/, OK?

I think tools is more appropriate for that stuff in bzr.dev

>> From a higher level, we should make sure that we can use launchpad and its translation services and focus on the minimal infrastructure we need to provide.
>
> qbzr, bzr-explorer and TortoiseBZR uses setup.py import-po command that imports from tar file exported from Launchpad.
> Launchpad may be able to put po files into branch directly, but I don't know about the feature much.

As I can say somebody already set up translations imports for
TortoiseBzr. I thought that was you.

I'm a bit lazy to play with automatic imports/exports on LP, although
those are promoted as preferred way now. But in my understanding it's
better to have separate branch for import/export and merge from it
regularly into trunk.

--
All the dude wanted was his rug back

« Back to merge proposal