Code review comment for lp:~songofacandy/bzr/i18n-utextwrap

Revision history for this message
Alexander Belchenko (bialix) wrote :

Vincent Ladeuil пишет:
>> On Windows osutils.terminal_width() returns the real terminal width, but
>> we need (osutils.terminal_width()-1) otherwise user will see extra blank
>> line when line filled up to that limit.
>
> Right. We need tests for that or we'll keep having this discussion. In any case, the windows implementation of osutils.terminal_width should take that into account so this proposal should have to care about it.
>
> Do we have a bug filed for that ?

I don't think so but sometimes we talked about this issue with you in
IRC, cause it affects selftest output.

--
All the dude wanted was his rug back

« Back to merge proposal