Code review comment for lp:~songofacandy/bzr/fix-524560

> > > * Don't like the style of having shadows in osutils that are almost-but-
> not-
> > > quite builtins or standard library functions.
>
> Just realised there's a clash with another current merge proposal here:
> <https://code.launchpad.net/~parthm/bzr/376388-dot-bazaar-
> ownership/+merge/19691>

Thanks for point it.
open_file() should fixes this and it.

> > Should we support this case on Python 2.4 on Windows?
> > If should, using os.fdopen(os.open()) may work on Python 2.4.
> > http://bazaar.launchpad.net/~songofacandy/bzr/fix-524560/revision/4742
>
> Python 2.5 is also pre-VS2005. Using O_NOINHERIT does work on everything,
> though if it's the best option I don't know.

OK. I should use O_NOINHERIT flag instead of 'N' mode.
I've fixed it now.