Code review comment for lp:~songofacandy/bzr/fix-524560

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

INADA Naoki wrote:
> I've found open with mode="wbN" is enough.
> mode 'N' means NOINHERIT on win32 and ignored on Linux.
>
> Should I remove osutils.open and add 'N' flag directly?

If that works, I would recommend it. But we need to make sure that it
doesn't cause problems with Python 2.4.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkuC2fkACgkQJdeBCYSNAAPWoACgoZQT+WU/bhw3CDVKhVBMgEjv
ZogAn1zgWNTubK4mjgIB8HlcsF+MsNqg
=UidF
-----END PGP SIGNATURE-----

« Back to merge proposal