Code review comment for lp:~songofacandy/bzr/fix-523746

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> I recall subprocess being very slow to import; it worries me that we'll
> be importing it all the time.
>
> A quick check on my machine took about 10ms to import, so its definitely
> noticable.
>
> -Rob
>

It can pretty easily be moved into the lazy_import section.

Also, this doesn't handle stuff like Unicode filenames that are valid on
disk, but not valid in user encoding. (Which can be pretty easy to
trigger on Windows.)

However, it is probably better than what we have today.

Actually, we have a different problem. In that 'get_user_encoding()' !=
'sys.get_filesystemencoding'. I'm not 100% sure what needs to be passed
to programs.

The real fix is to use CreateProcessW and pass it a unicode string,
rather than trying to get everything round-tripped across an encoding
barrier.

This may be a stepping point in that direction, though.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkt+9AQACgkQJdeBCYSNAANcDACeMCCHcSVntHnO3XkvWLzCj82R
H2IAoMGFEiBOXh+t4Z0W+C64WG59gPWo
=6JUh
-----END PGP SIGNATURE-----