Merge lp:~snwh/egtk/header-bar-additions into lp:~elementary-design/egtk/trunk

Proposed by Sam Hewitt
Status: Rejected
Rejected by: Danielle Foré
Proposed branch: lp:~snwh/egtk/header-bar-additions
Merge into: lp:~elementary-design/egtk/trunk
Diff against target: 49 lines (+20/-1)
2 files modified
gtk-3.0/apps.css (+9/-0)
gtk-3.0/gtk-widgets.css (+11/-1)
To merge this branch: bzr merge lp:~snwh/egtk/header-bar-additions
Reviewer Review Type Date Requested Status
Danielle Foré Needs Fixing
Review via email: mp+284525@code.launchpad.net

Commit message

added some header-bar specific styles

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

I'm not a fan of the way this affects linked buttons in (for example) Files.

Also be aware that the .header-bar class is no longer present in Gtk >=3.19. You should probably use .titlebar instead

review: Needs Fixing
Revision history for this message
Danielle Foré (danrabbit) wrote :

If you ever wanna revive this, please do so on GitHub

Unmerged revisions

631. By Sam Hewitt

added some header-bar specific styles

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'gtk-3.0/apps.css'
--- gtk-3.0/apps.css 2016-01-15 21:20:28 +0000
+++ gtk-3.0/apps.css 2016-01-30 23:12:51 +0000
@@ -31,6 +31,15 @@
31 0 1px 2px alpha (#000, 0.24);31 0 1px 2px alpha (#000, 0.24);
32}32}
3333
34/* Header bar */
35.header-bar .avatar {
36 border:none;
37 border-radius: 15%;
38 box-shadow: inset 0 0 0 1px alpha(#000, 0.25),
39 inset 0 1px 2px 0 alpha (#000, 0.45),
40 0 1px 0 0 alpha( #fff, 0.45);
41}
42
34/*************43/*************
35* Calculator *44* Calculator *
36*************/45*************/
3746
=== modified file 'gtk-3.0/gtk-widgets.css'
--- gtk-3.0/gtk-widgets.css 2016-01-13 05:10:09 +0000
+++ gtk-3.0/gtk-widgets.css 2016-01-30 23:12:51 +0000
@@ -1138,7 +1138,6 @@
1138 background-color: alpha (#000, 0.05);1138 background-color: alpha (#000, 0.05);
1139 background-image: none;1139 background-image: none;
1140 border-color: alpha (#000, 0.27);1140 border-color: alpha (#000, 0.27);
1141
1142 box-shadow: inset 0 0 0 1px alpha (#000, 0.05),1141 box-shadow: inset 0 0 0 1px alpha (#000, 0.05),
1143 0 1px 0 0 alpha (@bg_highlight_color, 0.30);1142 0 1px 0 0 alpha (@bg_highlight_color, 0.30);
1144}1143}
@@ -1625,6 +1624,17 @@
1625 border-radius: 2.5px;1624 border-radius: 2.5px;
1626}1625}
16271626
1627/* GraniteModeButton (linked full-height header-bar buttons) */
1628.header-bar .linked .button,
1629.header-bar .linked button {
1630 border-right-width:0px;
1631}
1632
1633.header-bar .linked .button:last-child,
1634.header-bar .linked button:last-child {
1635 border-right-width:1px;
1636}
1637
1628/********************1638/********************
1629* Notebook and Tabs *1639* Notebook and Tabs *
1630********************/1640********************/

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: