Code review comment for lp:~smspillaz/nux/nux.fix_1112321

On Fri, Feb 1, 2013 at 7:41 PM, Michi Henning
<email address hidden> wrote:
> As a general comment, there are hundreds of lines that repeat every five or ten lines, doing the same thing over and over again. It would probably help a lot in terms of the maintainability of the tests if there were a table containing the inputs and outputs. In that case, there would be the table (easy to read, one line per test), and something like ten or twenty lines of code for the single test that runs through the table.

I agree.

I note that the "xtest" set of tests in Nux appear to be mainly
acceptance/integration level tests, which makes the stateful testing
model slightly more acceptable. There's a lot of dependencies between
each of the tests, and they don't use an xUnit like framework.

The set-up and tear-down times would almost make separation not worth
it, although I'm pretty sure the tests take long enough with all those
sleep() statements used to get around the threading concerns.

We should focus on this later on.

> --
> https://code.launchpad.net/~smspillaz/nux/nux.fix_1112321/+merge/146098
> You are the owner of lp:~smspillaz/nux/nux.fix_1112321.

--
Sam Spilsbury