Code review comment for lp:~smspillaz/compiz/compiz.gles2.always-swapbuffers

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

It seems to work very nicely on intel. I have a couple of concerns though:

1. The glCopyPixels fallback works and is reliable. I would like to keep it unless there is a good reason not to. That way we don't raise the minimum system requirements unnecessarily.

2. We need a configuration option for people to be able to choose the old rendering method. There is a significant performance hit in (unthrottled) benchmark results with this change. So people need to have the option of going back to regional updates.

review: Needs Fixing

« Back to merge proposal