Code review comment for lp:~smspillaz/compiz/compiz.feature_1069112.cubeaddon

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

gcc 4.7.2 (quantal) BUILD_GLES:
/home/dan/bzr/compiz/tmp.112/plugins/opengl/src/screen.cpp: In member function ‘bool GLScreen::glInitContext(XVisualInfo*)’:
/home/dan/bzr/compiz/tmp.112/plugins/opengl/src/screen.cpp:547:24: error: invalid conversion from ‘void (*)(GLuint, GLsizei, const GLchar**, const GLint*) {aka void (*)(unsigned int, int, const char**, const int*)}’ to ‘GL::GLShaderSourceProc {aka void (*)(unsigned int, int, const char* const*, const int*)}’ [-fpermissive]

Seems to be the same change from:
https://code.launchpad.net/~compiz-team/compiz/compiz.fix_1095915/+merge/141851
so please add a prereq on that one.

review: Needs Resubmitting

« Back to merge proposal