Code review comment for lp:~smspillaz/compiz/compiz.feature_1069112.cubeaddon

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

BUILD_GLES fails:
/home/dan/bzr/compiz/tmp.112/plugins/cubeaddon/src/cubeaddon.cpp: In member function ‘void CubeaddonScreen::CubeCap::load(bool, bool, bool)’:
/home/dan/bzr/compiz/tmp.112/plugins/cubeaddon/src/cubeaddon.cpp:114:9: error: ‘GL_CLAMP_TO_BORDER’ was not declared in this scope
make[2]: *** [plugins/cubeaddon/CMakeFiles/cubeaddon.dir/src/cubeaddon.cpp.o] Error 1
make[1]: *** [plugins/cubeaddon/CMakeFiles/cubeaddon.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

----
Clang also fails:
In file included from /home/dan/bzr/compiz/tmp.112/plugins/cubeaddon/src/cubeaddon.cpp:26:
/home/dan/bzr/compiz/tmp.112/plugins/cubeaddon/src/cubeaddon.h:170:7: error:
      'CubeaddonWindow::glDraw' hides overloaded virtual function
      [-Werror,-Woverloaded-virtual]
        bool glDraw (const GLMatrix&, GLWindowPaintAttrib&,
             ^
/home/dan/bzr/compiz/tmp.112/plugins/cubeaddon/../opengl/include/opengl/opengl.h:849:15: note:
      hidden overloaded virtual function 'GLWindowInterface::glDraw' declared
      here
        virtual bool glDraw (const GLMatrix &matrix,
                     ^
In file included from /home/dan/bzr/compiz/tmp.112/plugins/cubeaddon/src/cubeaddon.cpp:26:
/home/dan/bzr/compiz/tmp.112/plugins/cubeaddon/src/cubeaddon.h:175:7: error:
      'CubeaddonWindow::glDrawTexture' hides overloaded virtual function
      [-Werror,-Woverloaded-virtual]
        void glDrawTexture (GLTexture *,
             ^
/home/dan/bzr/compiz/tmp.112/plugins/cubeaddon/../opengl/include/opengl/opengl.h:875:15: note:
      hidden overloaded virtual function 'GLWindowInterface::glDrawTexture'
      declared here
        virtual void glDrawTexture (GLTexture *texture, const GLMatrix &,
                     ^
2 errors generated.

review: Needs Fixing

« Back to merge proposal