Code review comment for lp:~smspillaz/compiz-core/fix_894688

Revision history for this message
Thomi Richards (thomir-deactivatedaccount) wrote :

ln 130 - is the change from 'geometry' to 'serverGeometry' intentional?

ln 214 - Why not write this as:

cScreen->damageRegion(oldGeometry + newGeometry);

ln 980 - this obviously only works as long as both structures have exactly
 the same contents and are laid out in exactly the same manner. I assume you have checked that this is the case?

As far as I can tell, this is looking good, with the few points mentioned above.

review: Needs Fixing

« Back to merge proposal