Code review comment for lp:~smspillaz/compiz-core/compiz-core.fix_924736.2

On Mon, 20 Feb 2012, Daniel van Vugt wrote:

> Review: Needs Fixing
>
> OK, I have re-tested this branch and compared it to lp:compiz-core. There are a few problems however, with at least 2 regressions introduced by this branch...
>
> 1. The fix to make semi-maximized windows not cast shadows on each other mostly works, but causes shadow-like artifacts appear when you slowly hover the mouse over the common border between the windows.
>

ack

> 2. Using lp:compiz-core, maximized windows do not cast shadows on adjacent monitors at all. That bug has seemingly already been fixed since oneiric. However this branch reintroduces that bug and causes adjacent monitors to show the shadow of maximized windows.
>

The problem was that maximized windows were not casting shadows /at all/.
This in itself was a bug[tm]

> 3. The branch name is misleading because it actually has nothing to do with "924736" any more.
>

ack

> Please log a bug for #1, fix #1 & #2, and resubmit using a more accurate branch name to resolve #3.
>
>
> --
> https://code.launchpad.net/~smspillaz/compiz-core/compiz-core.fix_924736.2/+merge/92727
> You are the owner of lp:~smspillaz/compiz-core/compiz-core.fix_924736.2.
>