Code review comment for lp:~smspillaz/compiz-core/compiz-core.fix_924736.2

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

<JohnLea> to answer the 2nd question first, no, semi-maximised windows should not cast shadows
                on each other
<JohnLea> also both maximised and semi-maximised windows should not cast shadows on to
                adjacent monitors

As for the other stuff -

8 - &frame->max_border_shadow_inactive,
9 + &frame->max_border_shadow_active,

That is a typo that needs to be fixed

21 + update_window_decoration_state (win);
22 + update_window_decoration_actions (win);
23 + update_window_decoration_icon (win);

That was causing quickly demaximized windows to retain maximized decorations

40 + if (gconf_client_dir_exists (client, "/apps/mutter/general", NULL))
41 + {
42 + new_width = gconf_client_get_int (client,
43 + MUTTER_DRAGGABLE_BORDER_WIDTH_KEY,
44 + NULL);
45 + }
46 + else
47 + {
48 + new_width = 7;
49 + }

That was causing no draggable border

« Back to merge proposal