Code review comment for lp:~smspillaz/compiz-core/compiz-core.fix-880707-test-v3

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

I really can't tell if the code has the intended effect, but it largely looks reasonable.

I presume from the comment trail that vanvugh will verify?

BTW the ARRAY_SIZE is better written as a simple template:

template<typename Type, size_t N>
inline size_t length_of(Type (&)[N]) { return N; }

review: Abstain

« Back to merge proposal