Merge lp:~smoser/ubuntu/quantal/lxc/lp-1066084 into lp:ubuntu/quantal/lxc

Proposed by Scott Moser
Status: Merged
Merge reported by: Serge Hallyn
Merged at revision: not available
Proposed branch: lp:~smoser/ubuntu/quantal/lxc/lp-1066084
Merge into: lp:ubuntu/quantal/lxc
Diff against target: 70 lines (+30/-1)
5 files modified
.pc/applied-patches (+1/-0)
debian/changelog (+7/-0)
debian/patches/0225-ubuntu-cloud-numeric-owner (+20/-0)
debian/patches/series (+1/-0)
templates/lxc-ubuntu-cloud.in (+1/-1)
To merge this branch: bzr merge lp:~smoser/ubuntu/quantal/lxc/lp-1066084
Reviewer Review Type Date Requested Status
Serge Hallyn Approve
Ubuntu branches Pending
Review via email: mp+129499@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Thanks, merged into ubuntu:lxc. I'm not sure how that will fall out when r opens up. Hopefully it gets copied over automatically.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file '.pc/applied-patches'
--- .pc/applied-patches 2012-10-04 17:08:11 +0000
+++ .pc/applied-patches 2012-10-12 19:19:22 +0000
@@ -103,3 +103,4 @@
1030222-debian-dhcp3-package1030222-debian-dhcp3-package
1040223-ubuntu-template-user-msg1040223-ubuntu-template-user-msg
1050224-ubuntu-templates-devtmpfs1050224-ubuntu-templates-devtmpfs
1060225-ubuntu-cloud-numeric-owner
106107
=== modified file 'debian/changelog'
--- debian/changelog 2012-10-04 18:43:50 +0000
+++ debian/changelog 2012-10-12 19:19:22 +0000
@@ -1,3 +1,10 @@
1lxc (0.8.0~rc1-4ubuntu38) UNRELEASED; urgency=low
2
3 * ubuntu-cloud template: use --numeric-owner when extracting root filesystems
4 with tar (LP: #1066084)
5
6 -- Scott Moser <smoser@ubuntu.com> Fri, 12 Oct 2012 15:17:16 -0400
7
1lxc (0.8.0~rc1-4ubuntu37) quantal; urgency=low8lxc (0.8.0~rc1-4ubuntu37) quantal; urgency=low
29
3 * update 0222-debian-dhcp3-package: use dhcp3-client, not server!10 * update 0222-debian-dhcp3-package: use dhcp3-client, not server!
411
=== added file 'debian/patches/0225-ubuntu-cloud-numeric-owner'
--- debian/patches/0225-ubuntu-cloud-numeric-owner 1970-01-01 00:00:00 +0000
+++ debian/patches/0225-ubuntu-cloud-numeric-owner 2012-10-12 19:19:22 +0000
@@ -0,0 +1,20 @@
1Description: ubuntu-cloud template: extract root tar with --numeric-owner
2 when extracting the tarball of the filesystem it must be done with
3 --numeric-owner. Without this argument, ownership is potentially
4 broken because tar converts the username/groupname to uid/gid.
5 this does not necessarily match the entries in /etc/passwd or group
6 inside the extracted root.
7Author: Scott Moser <smoser@ubuntu.com>
8Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/lxc/+bug/1066084
9Forwarded: no
10--- a/templates/lxc-ubuntu-cloud.in
11+++ b/templates/lxc-ubuntu-cloud.in
12@@ -341,7 +341,7 @@ mkdir -p /var/lock/subsys/
13 echo "Extracting container rootfs"
14 mkdir -p $rootfs
15 cd $rootfs
16- tar -zxf $cache/$filename
17+ tar --numeric-owner -zxf $cache/$filename
18
19
20 if [ $cloud -eq 0 ]; then
021
=== modified file 'debian/patches/series'
--- debian/patches/series 2012-10-04 17:08:11 +0000
+++ debian/patches/series 2012-10-12 19:19:22 +0000
@@ -105,3 +105,4 @@
1050222-debian-dhcp3-package1050222-debian-dhcp3-package
1060223-ubuntu-template-user-msg1060223-ubuntu-template-user-msg
1070224-ubuntu-templates-devtmpfs1070224-ubuntu-templates-devtmpfs
1080225-ubuntu-cloud-numeric-owner
108109
=== modified file 'templates/lxc-ubuntu-cloud.in'
--- templates/lxc-ubuntu-cloud.in 2012-10-04 17:08:11 +0000
+++ templates/lxc-ubuntu-cloud.in 2012-10-12 19:19:22 +0000
@@ -341,7 +341,7 @@
341 echo "Extracting container rootfs"341 echo "Extracting container rootfs"
342 mkdir -p $rootfs342 mkdir -p $rootfs
343 cd $rootfs343 cd $rootfs
344 tar -zxf $cache/$filename344 tar --numeric-owner -zxf $cache/$filename
345345
346346
347 if [ $cloud -eq 0 ]; then347 if [ $cloud -eq 0 ]; then

Subscribers

People subscribed via source and target branches