Merge ~smoser/ubuntu/+source/grub-legacy-ec2:fix/1786244-fix-read-from-stderr-upgrade-fail into ubuntu/+source/grub-legacy-ec2:ubuntu/devel

[Scott Moser]

Do not attempt to read from stderr, only from stdin and if it is a terminal.

Previously, if /boot/grub/menu.lst did not exist, then
the a postinst would attempt read from stderr, which is not likely
opened for reading. This does two things:
 a.) reads from stdin (which makes more sense)
 b.) only attempts to do so if input is a terminal.

If not 'a' and 'b' then write /boot/grub/menu.lst from template
rather than exiting fail.

LP: #1786244

see commit message

[Christian Ehrhardt  (paelzer)]

The Change itself LGTM, thanks for working that out.

The changelog is currently not directed at anything, please remember to update that according to what you want to upload to.

[Christian Ehrhardt  (paelzer)]

review: Approve

[Scott Moser (smoser)]

Ack in the release in changelog. Thanks.

On Sat, Dec 15, 2018, 3:41 AM Christian Ehrhardt  <
<email address hidden> wrote:

> Review: Approve
>
>
> --
>
> https://code.launchpad.net/~smoser/ubuntu/+source/grub-legacy-ec2/+git/grub-legacy-ec2/+merge/360897
> You are the owner of
> ~smoser/ubuntu/+source/grub-legacy-ec2:fix/1786244-fix-read-from-stderr-upgrade-fail.
>

diff --git a/debian/changelog b/debian/changelog
index 2385875..e537936 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+grub-legacy-ec2 (1:1ubuntu1) UNRELEASED; urgency=medium
+
+  * Fix a bug occuring from postinst if /boot/grub/menu.lst did
+    not exist (LP: #1786244).
+
+ -- Scott Moser <[e-mail]>  Thu, 13 Dec 2018 17:12:28 -0500
+
 grub-legacy-ec2 (1:1) bionic; urgency=medium
 
   * Split package out of cloud-init source. (LP: #1758420)
diff --git a/debian/update-grub-legacy-ec2 b/debian/update-grub-legacy-ec2
index c1c9dc7..937170d 100755
--- a/debian/update-grub-legacy-ec2
+++ b/debian/update-grub-legacy-ec2
@@ -1095,10 +1095,13 @@ else
 		echo >&2
 		echo "Generating $menu_file" >&2
 		answer=y
-	else
+	elif [ -t 0 ]; then
 		echo -n "Would you like $menu_file generated for you? " >&2
 		echo -n "(y/N) " >&2
-		read answer <&2
+		read answer
+	else
+		echo "Input is not from a terminal. Creating new $menu_file." >&2
+		answer=y
 	fi
 
 	case "$answer" in