Code review comment for ~smoser/ssh-import-id:ubuntu/devel

Revision history for this message
Scott Moser (smoser) wrote :

It seems fine to me to have a debian/ dir in upstream. If upstream wants to make packages, for testing, then they probably want to have a debian/ dir to do so, and not managing that dir in git would be silly.

I'm not set on that staying, but as it is right now this is almost how curtin does it.

In curtin, we have deleted the debian/changelog file to avoid having conflicts between the ubuntu/debian branch and master branch, and I think that seems sane to do here also.

The debian/ dir means that './tools/build-deb' creates a deb from the current branch.

Anyway. thanks for reviews. I will upload.

« Back to merge proposal