Code review comment for ~smoser/ssh-import-id:ubuntu/devel

This is an relic of the fact that I started this project / package, many
years ago, and use the same process that I've used for the dozens of
projects + packages that I've maintained. In each of those, I simply keep
the debian/ directory in the master upstream source (other distros are
welcome to ignore it). And I use the debian/changelog to cover both the
packaging changes, as well as all of the upstream source code changes
(which are automatically duplicated, verbatim, in source code revision
control). Scott and I have shared this access and process successfully on
other projects/packages, and I'd prefer to keep it that way.

On Tue, Feb 11, 2020 at 11:03 AM Robie Basak <email address hidden>
wrote:

> Review: Abstain
>
> I was asked to review this but then I see that Dustin beat me to it.
>
> I'm puzzled by the debian/ directory existing in the master branch. This
> leaves me confused about what the usual release management process is for
> the project.
>
> However, as Dustin and Scott both know the project already and they have
> both approved this MP, I'll leave it here - no need for me to go into it as
> well then.
>
> Diff comments:
>
> > diff --git a/debian/control b/debian/control
> > index d55c9bf..8f5a7f4 100644
> > --- a/debian/control
> > +++ b/debian/control
> > @@ -10,8 +10,8 @@ Build-Depends: debhelper (>= 10),
> > python3-setuptools
> > Standards-Version: 4.1.3
> > Homepage: http://launchpad.net/ssh-import-id
> > -Vcs-Browser:
> http://bazaar.launchpad.net/~ssh-import-id/ssh-import-id/trunk/files
> > -Vcs-Bzr: https://code.launchpad.net/~ssh-import-id/ssh-import-id/trunk
> > +Vcs-Browser: https://git.launchpad.net/ssh-import-id
> > +Vcs-git: https://git.launchpad.net/ssh-import-id
>
> Vcs-Git is the normal capitalization, although admittedly field names are
> specified to be case insensitive.
>
> >
> > Package: ssh-import-id
> > Architecture: all
>
>
> --
>
> https://code.launchpad.net/~smoser/ssh-import-id/+git/ssh-import-id/+merge/378909
> You are reviewing the proposed merge of ~smoser/ssh-import-id:ubuntu/devel
> into ssh-import-id:ubuntu/devel.
>