Code review comment for lp:~smoser/nova/lp853330

Revision history for this message
Soren Hansen (soren) wrote :

Thanks so much for highlighting and addressing this bug.

A couple of issues:

 * qemu-img's output may be translated. We need to make sure LANG and LC_* either are set to "C" or not set at all, otherwise parsing its output might fail.

 * (as you pointed out yourself to me on IRC:) You don't clean up after yourself if you raise the ImageUnacceptable exception.

 * Calling the final two arguments to fetch_to_raw "_user_id" and "_project_id" suggests they're not used, while in fact they're passed on to fetch (which may or may not ignore them).

review: Needs Fixing

« Back to merge proposal