Code review comment for lp:~smoser/maas/lp1402042

Revision history for this message
Raphaƫl Badin (rvb) wrote :

> the only comment i have is that CURTIN_KERNEL_CMDLINE_NAME seems not useful.
> the name 'KERNEL_CMDLINE_COPY_TO_INSTALL_SEP' is obnoxiously large, but it
> better describes it.
> CURTIN_KERNEL_CMDLINE_NAME doesn't really mean anything if you read that by
> itself.
>
> i fully accept that this is a bikeshed, but as i said in the description i'd
> like to have the name stay the same between maas and curtin.
>
> its up to you, i dont really have a strong feelings.

Okay, sure, let's rename CURTIN_KERNEL_CMDLINE_NAME.

I agree it's convenient if the names are the same but note that the MAAS instance doesn't need to be exported (aka put in __all__) because this is only used in this module (well, and the tests but that doesn't count).

« Back to merge proposal