Code review comment for lp:~smoser/maas/lp1402042

Revision history for this message
Scott Moser (smoser) wrote :

the only comment i have is that CURTIN_KERNEL_CMDLINE_NAME seems not useful.
the name 'KERNEL_CMDLINE_COPY_TO_INSTALL_SEP' is obnoxiously large, but it better describes it.
CURTIN_KERNEL_CMDLINE_NAME doesn't really mean anything if you read that by itself.

i fully accept that this is a bikeshed, but as i said in the description i'd like to have the name stay the same between maas and curtin.

its up to you, i dont really have a strong feelings.

« Back to merge proposal