Code review comment for ~smoser/maas:cleanup/render-curtin-config-internally

Revision history for this message
Andres Rodriguez (andreserl) wrote :

That's my only concern, we need to make sure the upgrade path doesn't break
and this continuous to work with those that modify their curtin scripts.
Which is a lot of people atm.

On Mon, Oct 23, 2017 at 9:16 AM, Blake Rouse <email address hidden>
wrote:

> I think the general idea is great, but we need to think about the upgrade
> path.
>
> What happens if they made changes to the sections that you have not made
> internal? Will there changes override the internal changes?
>
> Also this is more of a future thing, but I would prefer to see the
> templates move into the database with an API, because at the moment with
> HA, these are a problem.
> --
> https://code.launchpad.net/~smoser/maas/+git/maas/+merge/332573
> Your team MAAS Committers is subscribed to branch maas:master.
>

--
Andres Rodriguez
Engineering Manager, MAAS
Canonical USA, Inc.

« Back to merge proposal