Code review comment for lp:~smoser/curtin/trunk.lp1520400

You can still dump in json. We have an existing yaml load/read that does
exactly what you want.

On Tue, Jan 5, 2016 at 1:46 PM, Scott Moser <email address hidden> wrote:

>
>
> Diff comments:
>
> > === modified file 'curtin/url_helper.py'
> > --- curtin/url_helper.py 2016-01-04 18:03:45 +0000
> > +++ curtin/url_helper.py 2016-01-05 18:06:23 +0000
> > @@ -160,7 +160,7 @@
> > def read_skew_file(self):
> > if self.skew_data_file and os.path.isfile(self.skew_data_file):
> > with open(self.skew_data_file, mode="r") as fp:
> > - return json.load(fp.read())
> > + return json.load(fp)
> > return None
> >
>
> since we author and consume, i'd prefer json. json is more a machine
> format. also as it is right now, url_helper is very stand alone. it doesnt
> depend on any other curtin things.
>
> > def update_skew_file(self, host, value):
>
>
> --
> https://code.launchpad.net/~smoser/curtin/trunk.lp1520400/+merge/281682
> Your team curtin developers is requested to review the proposed merge of
> lp:~smoser/curtin/trunk.lp1520400 into lp:curtin.
>