Code review comment for ~smoser/curtin:fix/1527664-grub-cmdline-linux-default-in-default-grub

Revision history for this message
Scott Moser (smoser) wrote :

@Ryan,
I simplified the code a bit.
I was over-engineering the shell_config_update. I was trying to account for the case where the /etc/default/grub file did not exist and to let the caller handle the behavior of what to do if it did not.

We can add that function later if we want.
For now, the behavior is
 - if /etc/default/grub exists and has GRUB_CMDLINE_LINUX_DEFAULT= in it, then edit in place.
 - otherwise append to it

« Back to merge proposal