Merge ~smoser/curtin:fix/bigger-root-volumes into curtin:master

[Scott Moser]

vmtests: Increase size of root filesystems.

I believe that this change removes the final 2G root (/) filesystems.
These 2G filesystems were too small to handle upgrades sometimes.
Things that lead to this state:
 a.) we started testing with propsed enabled (and upgrade to it)
 b.) the failing cases here were Trusty HWE tests, which end up
     getting 2 kernels installed and 2 update-initramfs and such.

That worst case scenario led to the following output of apt:
  Need to get 2404 kB of archives.
  After this operation, 10.9 MB of additional disk space will be used.
  Need to get 1467 kB of archives.
  After this operation, 4904 kB of additional disk space will be used.
  Need to get 68.3 MB of archives.
  After this operation, 308 MB of additional disk space will be used.
  Need to get 63.9 MB of archives.
  After this operation, 275 MB of additional disk space will be used.

see commit message

[Scott Moser (smoser)]

proposed test running at
 https://jenkins.ubuntu.com/server/job/curtin-vmtest-devel-debug/84/console

+ ./tools/jenkins-runner -p 4 tests/vmtests/test_mdadm_bcache.py

CURTIN_VMTEST_ADD_REPOS=proposed
CURTIN_VMTEST_CURTIN_EXE_VERSION=18.1-41-g510e2c4f
CURTIN_VMTEST_CURTIN_VERSION=18.1-41-g510e2c4f

[Server Team CI bot (server-team-bot)]

PASSED: Continuous integration, rev:24f7a7f41b079be8d52f632f12143f12d7be5258
https://jenkins.ubuntu.com/server/job/curtin-ci/1012/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/1012
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/1012
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/1012
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=torkoal/1012

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/1012/rebuild

review: Approve (continuous-integration)

[Server Team CI bot (server-team-bot)]

PASSED: Continuous integration, rev:510e2c4f16796f434c2dad79663fd6a021b99249
https://jenkins.ubuntu.com/server/job/curtin-ci/1013/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/1013
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/1013
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/1013
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=torkoal/1013

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/1013/rebuild

review: Approve (continuous-integration)

[Ryan Harper (raharper)]

Is it worth trying to build a common root partition that all of the configs use? If we find out that 3G isn't enough, then how many more files do we touch to bump the value to the next required size?

Possibly not worth the effort since we've gone this long without triggering it.

I'm OK with punting on this.

review: Approve

[Scott Moser (smoser)]

yah, i'd considered that... just more work and not a lot of reason for that right nw.

diff --git a/examples/tests/mirrorboot-msdos-partition.yaml b/examples/tests/mirrorboot-msdos-partition.yaml
index 1ce4220..2b111a7 100644
--- a/examples/tests/mirrorboot-msdos-partition.yaml
+++ b/examples/tests/mirrorboot-msdos-partition.yaml
@@ -47,7 +47,7 @@ storage:
        name: md0-part1
        number: 1
        offset: 4194304B
-       size: 2GB
+       size: 3GB
        type: partition
        uuid: 4f4fa336-2762-48e4-ae54-9451141665cd
        wipe: superblock
@@ -55,7 +55,7 @@ storage:
        id: md0-part2
        name: md0-part2
        number: 2
-       size: 2.5GB
+       size: 1.5GB
        type: partition
        uuid: c2d21fd3-3cde-4432-8eab-f08594bbe76e
        wipe: superblock
diff --git a/examples/tests/mirrorboot-uefi.yaml b/examples/tests/mirrorboot-uefi.yaml
index e1f393f..ca55be9 100644
--- a/examples/tests/mirrorboot-uefi.yaml
+++ b/examples/tests/mirrorboot-uefi.yaml
@@ -30,7 +30,7 @@ storage:
     id: sda-part2
     name: sda-part2
     number: 2
-    size: 2G
+    size: 3G
     type: partition
     uuid: 47c97eae-f35d-473f-8f3d-d64161d571f1
     wipe: superblock
@@ -38,7 +38,7 @@ storage:
     id: sda-part3
     name: sda-part3
     number: 3
-    size: 2G
+    size: 1G
     type: partition
     uuid: e3202633-841c-4936-a520-b18d1f7938ea
     wipe: superblock
@@ -56,7 +56,7 @@ storage:
     id: sdb-part2
     name: sdb-part2
     number: 2
-    size: 2G
+    size: 3G
     type: partition
     uuid: a33a83dd-d1bf-4940-bf3e-6d931de85dbc
     wipe: superblock
@@ -72,7 +72,7 @@ storage:
     id: sdb-part3
     name: sdb-part3
     number: 3
-    size: 2G
+    size: 1G
     type: partition
     uuid: 27e29758-fdcf-4c6a-8578-c92f907a8a9d
     wipe: superblock