Merge ~smoser/curtin:feature/add-xenial-tox-env into curtin:master

[Scott Moser]

tox: add a xenial environments, default envlist changes.

A previous commit used mock.assert_called, which is not
present in xenial versions of mock so build would fail on xenial.
Due to bugs that are present in the trusty versions of mock it would
pass there.

So we add a tox environment 'xenial-py3' and add that to the
default set of environments that are run with a 'tox' invocation.

Other changes to the envlist here:
a.) make it multiple lines for easier future diffing.
b.) run py3-flake8 first, it runs quickly and gives good feedback.
c.) drop trusty-check which was running trusty pyflakes. We do not
    run pyflakes in package build any more.
d.) replace trusty-py3 with xenial-py3. Just to save time in default 'tox'
    run we only run one "old" python3 unit tests.

see commit message

[Server Team CI bot (server-team-bot)]

FAILED: Continuous integration, rev:6fbc2910703f7907b4e7a6bdce990f6e1505bba3
https://jenkins.ubuntu.com/server/job/curtin-ci/942/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/942/console
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/942/console
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/942/console
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/942/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/942/rebuild

review: Needs Fixing (continuous-integration)

[Ryan Harper (raharper)]

From verbal discussions:

1) No need for pep8, pyflakes as those are not called in the make check path
2) We should add xenial-py27 but we can drop trusty-py27

e358ac3... by Scott Moser on 2018-05-22

updates

[Scott Moser (smoser)]

Changes I made:

a.) move py3-flake8 up to run early in 'tox' default. it runs fast and catches some errors.
b.) drop running of 'trusty-check' by default. we do not run this in our package builds any more.
c.) add xenial-py27 environment. (and make xenial-py3 share the base 'xenial' with it).
d.) we are not running pyflakes or pycodestyle/pep8 in xenial- environments.

[Server Team CI bot (server-team-bot)]

FAILED: Continuous integration, rev:e358ac3deae0749d48360c2abb026baae753232a
https://jenkins.ubuntu.com/server/job/curtin-ci/952/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/952/console
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/952/console
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/952/console
    FAILURE: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/952/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/952/rebuild

review: Needs Fixing (continuous-integration)

[Server Team CI bot (server-team-bot)]

PASSED: Continuous integration, rev:
https://jenkins.ubuntu.com/server/job/curtin-ci/953/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/953
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/953
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/953
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/953

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/953/rebuild

review: Approve (continuous-integration)

[Ryan Harper (raharper)]

Looks good, some general questions about the envlist inline.

[Chad Smith (chad.smith)]

Approve given the minor tox fix inline

review: Approve

e4427f7... by Scott Moser on 2018-05-23

fix use of python3 by xenial-py27. thanks chad.

[Scott Moser (smoser)]

At some point in the future, further changes will come.

I put a trello card at:
  https://trello.com/c/HTMRxCd2

And a hackmd.io at https://hackmd.io/9L0oxV1oRUOlSqoSBdP1ZQ?view
that describes what we want to get to.

[Server Team CI bot (server-team-bot)]

PASSED: Continuous integration, rev:e4427f78bd94938ac0d73c401b60cbe8e4e131b0
https://jenkins.ubuntu.com/server/job/curtin-ci/958/
Executed test runs:
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/958
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-arm64/958
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-ppc64el/958
    SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-s390x/958

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/curtin-ci/958/rebuild

review: Approve (continuous-integration)

[Scott Moser (smoser)]

An upstream commit landed for this bug.

To view that commit see the following URL:
https://git.launchpad.net/curtin/commit/?id=f98eb1bf

diff --git a/tox.ini b/tox.ini
index c1748c3..6f14381 100644
--- a/tox.ini
+++ b/tox.ini
@@ -1,7 +1,14 @@
 [tox]
 minversion = 1.6
 skipsdist = True
-envlist = py27, py3, py3-flake8, py3-pylint, py27-pylint, trusty-check, trusty-py27, trusty-py3
+envlist =
+   py3-flake8,
+   py27,
+   py3,
+   py3-pylint,
+   py27-pylint,
+   trusty-py27,
+   xenial-py3
 
 [tox:jenkins]
 downloadcache = ~/cache/pip
@@ -91,6 +98,25 @@ basepython = python3
 commands = {envpython} {toxinidir}/tools/noproxy nosetests \
     {posargs:tests/unittests}
 
+[testenv:xenial]
+deps =
+   mock==1.3.0
+   nose==1.3.7
+   pyyaml==3.11
+   oauthlib==1.0.3
+
+[testenv:xenial-py27]
+basepython = python27
+deps = {[testenv:xenial]deps}
+commands = {envpython} {toxinidir}/tools/noproxy nosetests \
+    {posargs:tests/unittests}
+
+[testenv:xenial-py3]
+basepython = python3
+deps = {[testenv:xenial]deps}
+commands = {envpython} {toxinidir}/tools/noproxy nosetests \
+    {posargs:tests/unittests}
+
 [testenv:tip-pycodestyle]
 commands = {envpython} -m pycodestyle {posargs:curtin/ tests/ tools/}
 deps = pycodestyle