Merge ~smoser/curtin:cleanup/make-basic-uefi-more-basic-no-xfs into curtin:master

Proposed by Scott Moser
Status: Merged
Approved by: Scott Moser
Approved revision: 08e1725286c1f78cb2b5e4885ae4d9792f4e7ec4
Merged at revision: 08e1725286c1f78cb2b5e4885ae4d9792f4e7ec4
Proposed branch: ~smoser/curtin:cleanup/make-basic-uefi-more-basic-no-xfs
Merge into: curtin:master
Diff against target: 50 lines (+1/-16)
2 files modified
examples/tests/uefi_basic.yaml (+0/-15)
tests/vmtests/test_uefi_basic.py (+1/-1)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
Ryan Harper (community) Approve
Review via email: mp+337192@code.launchpad.net

Commit message

tests: remove xfs filesystem from basic uefi test.

The test_uefi_basic.py file reports to be 'basic' test of uefi.
However, it also tests xfs filesystem support.
In order to make it more basic, just drop the xfs.

The real motivation here is to later enable a precise (12.04)
installation test done inside a 14.04 or 16.04 environment.
Each of those scenarios cause mounting problems of the xfs partition
when the 12.04 kernel boots. That is because the mkfs.xfs command
enabled options that were not supported in the older kernel.

Description of the change

see commit message

To post a comment you must log in.
Revision history for this message
Scott Moser (smoser) wrote :
Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Ryan Harper (raharper) wrote :

I would have been happy with a s,xfs,ext4,g but sure.

review: Approve
Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/examples/tests/uefi_basic.yaml b/examples/tests/uefi_basic.yaml
2index 25d896c..1f49fa9 100644
3--- a/examples/tests/uefi_basic.yaml
4+++ b/examples/tests/uefi_basic.yaml
5@@ -30,12 +30,6 @@ storage:
6 size: 3G
7 type: partition
8 wipe: superblock
9- - id: id_disk0_part3
10- number: 3
11- size: 1G
12- type: partition
13- wipe: superblock
14- device: id_disk0
15 - fstype: fat32
16 id: id_efi_format
17 label: efi
18@@ -46,19 +40,10 @@ storage:
19 label: root
20 type: format
21 volume: id_disk0_part2
22- - id: id_home_format
23- label: home
24- type: format
25- fstype: xfs
26- volume: id_disk0_part3
27 - device: id_root_format
28 id: id_root_mount
29 path: /
30 type: mount
31- - device: id_home_format
32- type: mount
33- path: /home
34- id: id_home_mount
35 - device: id_efi_format
36 id: id_efi_mount
37 path: /boot/efi
38diff --git a/tests/vmtests/test_uefi_basic.py b/tests/vmtests/test_uefi_basic.py
39index 1fbf162..712075c 100644
40--- a/tests/vmtests/test_uefi_basic.py
41+++ b/tests/vmtests/test_uefi_basic.py
42@@ -13,7 +13,7 @@ class TestBasicAbs(VMBaseClass):
43 conf_file = "examples/tests/uefi_basic.yaml"
44 extra_disks = ['4G']
45 uefi = True
46- disk_to_check = [('main_disk', 1), ('main_disk', 2), ('main_disk', 3)]
47+ disk_to_check = [('main_disk', 1), ('main_disk', 2)]
48 collect_scripts = VMBaseClass.collect_scripts + [textwrap.dedent("""
49 cd OUTPUT_COLLECT_D
50 blkid -o export /dev/vda > blkid_output_vda

Subscribers

People subscribed via source and target branches