Code review comment for ~smoser/curtin:feature/bug-1746348-fsimage-support

Revision history for this message
Ryan Harper (raharper) wrote :

I think the commit message should clarify fsimage means squasfs-based image; especially regarding the comment about other image types.

If we want to keep fsimage as generic (it *could* be used to install the ext4 root-image) then maybe we should add a test (even if that's not what we'd use in practice). Thoughts?

Some more questions and items inline.

« Back to merge proposal