Code review comment for ~smoser/cloud-init:fix/1134036-locale-message-change

Revision history for this message
Steve Langasek (vorlon) wrote :

Improving the situation "a bit" does not address my concerns. As long as users of client-side English locales have such a message taking up any real estate at login, I consider this unresolved. From our discussion and the git history I don't see any evidence that this was subject to any sort of high-level design review when it was added; I don't think it's appropriate to have a higher barrier for its removal.

If you are concerned about not hard-coding implementation details of Ubuntu minimal images into this script, then the simplest way to address is to remove the warning message unconditionally. This would be consistent with the long-term design goals for openssh.

review: Disapprove

« Back to merge proposal