Code review comment for ~smoser/cloud-init:fix/ds-identify-smartos-is-container
Revision history for this message
| Scott Moser (smoser) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
1. Order doesn't really matter, the end result is the same. we can change them but I dont consider that a problem unless I'm misunderstanding.
2. shell case insenstive matching is costly, so I had just done case sensitive there and the case insensitive in python.
I've added a commit to put python in case-sensitive match.
3. I think we *are* correctly going to return None in get_data on SmartOS if there is no METADATA_SOCKFILE .
get_smartos_environ doesn't check for the file, but when the client is created, a 'exists' is immediately done, and *that* will check for the presene of that file.