+1 here, thanks for this change I'll trust "${PATH_ROOT}/native/.zonecontrol/metadata.sock" exists on SmartOS for our use case here. I validated that we don't accidentally detect other datasources even if SmartOS is first in datasource_list. The only question I had (as I have no SmartOS account) is whether we still detect SmartOS on the desired non-container platform and it feels a bit strange that we aren't detecting/rejecting using the same type of logic in DataSourceSmartOS that ds-identify is using, but that may be minutia that doesn't really matter (as it'd be platform sub-type detection difference which would still be using the proper base datasource).
+1 here, thanks for this change I'll trust "${PATH_ ROOT}/native/ .zonecontrol/ metadata. sock" exists on SmartOS for our use case here. I validated that we don't accidentally detect other datasources even if SmartOS is first in datasource_list. The only question I had (as I have no SmartOS account) is whether we still detect SmartOS on the desired non-container platform and it feels a bit strange that we aren't detecting/rejecting using the same type of logic in DataSourceSmartOS that ds-identify is using, but that may be minutia that doesn't really matter (as it'd be platform sub-type detection difference which would still be using the proper base datasource).