Code review comment for ~smoser/cloud-init:feature/puppet_4

Revision history for this message
Romanos Skiadas (rski) wrote :

>You made the config *dir* configurable, but assumed file name 'puppet.conf'
>inside that. Trunk had previously mad a constant for the config file path.

>Was there a reason you chose to allow config of the directory but not the filename?
If I recall correctly, it was because the filename was the same, but the directory was what changed, but practically either one could have been a variable.

Thanks for rebasing and merging this!

« Back to merge proposal