Code review comment for ~smoser/cloud-init:bug/lp-1731868-unset-var-in-ds-identify

On Tue, Dec 12, 2017 at 12:12 PM, Scott Moser <email address hidden>
wrote:

> wrt shellcheck, it did not find this error, and generally complains about
> too many things.
> I've seen it and it *can* be useful, but not immediately.
>
> It lists 113 things, 2 of which were valid (unused variables).
>

Besides the local, the rest seemed pretty valid.

>
> The '--exclude' that you'd have to pass are coarsely grained, and I'm not
> interested in litering code with '#make-shellcheck-happy'
>

I don't want to do that either, but it suggests reasonable fixes IMO.

>
> http://paste.ubuntu.com/26171686/
> --
> https://code.launchpad.net/~smoser/cloud-init/+git/cloud-
> init/+merge/335086
> You are reviewing the proposed merge of ~smoser/cloud-init:bug/lp-
> 1731868-unset-var-in-ds-identify into cloud-init:master.
>