Merge ~smoser/cloud-init:cleanup/cii-no-curtin-ppa into cloud-init:master

Proposed by Scott Moser
Status: Merged
Merged at revision: 7624348712b4502f0085d30c05b34dce3f2ceeae
Proposed branch: ~smoser/cloud-init:cleanup/cii-no-curtin-ppa
Merge into: cloud-init:master
Diff against target: 48 lines (+6/-6)
2 files modified
tests/cloud_tests/testcases/modules/apt_configure_sources_ppa.py (+3/-3)
tests/cloud_tests/testcases/modules/apt_configure_sources_ppa.yaml (+3/-3)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
Joshua Powers (community) Approve
cloud-init Commiters Pending
Review via email: mp+333975@code.launchpad.net

Commit message

integration test: replace curtin test ppa with cloud-init test ppa.

Cloud-init integration tests should not depend on a curtin test ppa.
We already had a cloud-init test ppa for explicitly this purpose.
Just use it instead.

To post a comment you must log in.
Revision history for this message
Joshua Powers (powersj) wrote :

+1 This looked very familiar, as in we already changed this [1], but it appears we didn't change all the places. This removes the final references to curtin.

[1] https://github.com/cloud-init/cloud-init/commit/067721672570cc83d54d2c2d5677eeb79bef85e2

review: Approve
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:34a38c5df0ec85eaf68807f5358af61b043f587d
https://jenkins.ubuntu.com/server/job/cloud-init-ci/517/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    SUCCESS: Ubuntu LTS: Build
    SUCCESS: Ubuntu LTS: Integration
    SUCCESS: MAAS Compatability Testing
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/517/rebuild

review: Approve (continuous-integration)

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tests/cloud_tests/testcases/modules/apt_configure_sources_ppa.py b/tests/cloud_tests/testcases/modules/apt_configure_sources_ppa.py
2index d299e9a..dfbdead 100644
3--- a/tests/cloud_tests/testcases/modules/apt_configure_sources_ppa.py
4+++ b/tests/cloud_tests/testcases/modules/apt_configure_sources_ppa.py
5@@ -11,13 +11,13 @@ class TestAptconfigureSourcesPPA(base.CloudTestCase):
6 """Test specific ppa added."""
7 out = self.get_data_file('sources.list')
8 self.assertIn(
9- 'http://ppa.launchpad.net/curtin-dev/test-archive/ubuntu', out)
10+ 'http://ppa.launchpad.net/cloud-init-dev/test-archive/ubuntu', out)
11
12 def test_ppa_key(self):
13 """Test ppa key added."""
14 out = self.get_data_file('apt-key')
15 self.assertIn(
16- '1BC3 0F71 5A3B 8612 47A8 1A5E 55FE 7C8C 0165 013E', out)
17- self.assertIn('Launchpad PPA for curtin developers', out)
18+ '1FF0 D853 5EF7 E719 E5C8 1B9C 083D 06FB E4D3 04DF', out)
19+ self.assertIn('Launchpad PPA for cloud init development team', out)
20
21 # vi: ts=4 expandtab
22diff --git a/tests/cloud_tests/testcases/modules/apt_configure_sources_ppa.yaml b/tests/cloud_tests/testcases/modules/apt_configure_sources_ppa.yaml
23index 9efdae5..b997bcf 100644
24--- a/tests/cloud_tests/testcases/modules/apt_configure_sources_ppa.yaml
25+++ b/tests/cloud_tests/testcases/modules/apt_configure_sources_ppa.yaml
26@@ -2,7 +2,7 @@
27 # Add a PPA to source.list
28 #
29 # NOTE: on older ubuntu releases the sources file added is named
30-# 'curtin-dev-test-archive-trusty', without 'ubuntu' in the middle
31+# 'cloud-init-dev-test-archive-trusty', without 'ubuntu' in the middle
32 required_features:
33 - apt
34 - ppa
35@@ -14,11 +14,11 @@ cloud_config: |
36 source1:
37 keyid: 0165013E
38 keyserver: keyserver.ubuntu.com
39- source: "ppa:curtin-dev/test-archive"
40+ source: "ppa:cloud-init-dev/test-archive"
41 collect_scripts:
42 sources.list: |
43 #!/bin/bash
44- cat /etc/apt/sources.list.d/curtin-dev-ubuntu-test-archive-*.list
45+ cat /etc/apt/sources.list.d/cloud-init-dev-ubuntu-test-archive-*.list
46 apt-key: |
47 #!/bin/bash
48 apt-key finger

Subscribers

People subscribed via source and target branches