Merge ~smoser/cloud-init:fix/git-describe-specific-abbrev into cloud-init:master
Proposed by
Scott Moser
Status: | Merged |
---|---|
Approved by: | Chad Smith |
Approved revision: | 6eb4dc24fe314ce5c98b05b21988402cda95afce |
Merged at revision: | 6eb4dc24fe314ce5c98b05b21988402cda95afce |
Proposed branch: | ~smoser/cloud-init:fix/git-describe-specific-abbrev |
Merge into: | cloud-init:master |
Diff against target: |
25 lines (+2/-2) 2 files modified
tools/make-tarball (+1/-1) tools/read-version (+1/-1) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Chad Smith | Approve | ||
Ryan Harper | Approve | ||
Review via email: mp+331883@code.launchpad.net |
Commit message
tools: Give specific --abbrev=8 to "git describe"
The tools that use "git describe" were just assuming a consisent
number of characters in the hash. It seems ubuntu 16.04 would use 7
and later versions use 8. To avoid that discrepency in developer
environments, set it to 8.
To post a comment you must log in.
+1
Ran into this on my Xenial setup when preparing an upload to arful. This fixes this.