Merge ~smoser/cloud-init:fix/run-centos-unbound-var into cloud-init:master

Proposed by Scott Moser
Status: Merged
Merged at revision: 33d573907d3ffc790e28102ecac15c3be6a85462
Proposed branch: ~smoser/cloud-init:fix/run-centos-unbound-var
Merge into: cloud-init:master
Diff against target: 13 lines (+1/-1)
1 file modified
tools/run-centos (+1/-1)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
Chad Smith Approve
Review via email: mp+327896@code.launchpad.net

Commit message

tools/run-centos: make running with no argument show help.

If you ran tools/run-centos without an argument it would fail due
to 'set -u' like:
  ./tools/run-centos: line 266: 1: unbound variable

To post a comment you must log in.
Revision history for this message
Chad Smith (chad.smith) wrote :

+1 LGTM!

review: Approve
Revision history for this message
Server Team CI bot (server-team-bot) wrote :

PASSED: Continuous integration, rev:33d573907d3ffc790e28102ecac15c3be6a85462
https://jenkins.ubuntu.com/server/job/cloud-init-ci/76/
Executed test runs:
    SUCCESS: Checkout
    SUCCESS: Unit & Style Tests
    SUCCESS: Ubuntu LTS: Build
    SUCCESS: Ubuntu LTS: Integration
    SUCCESS: CentOS 6 & 7: Build & Test
    IN_PROGRESS: Declarative: Post Actions

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/server/job/cloud-init-ci/76/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tools/run-centos b/tools/run-centos
2index b10e3bc..d44d514 100755
3--- a/tools/run-centos
4+++ b/tools/run-centos
5@@ -262,7 +262,7 @@ main() {
6 return 0
7 }
8
9-if [ "$1" = "prep" ]; then
10+if [ "${1:-}" = "prep" ]; then
11 shift
12 prep "$@"
13 else

Subscribers

People subscribed via source and target branches