Merge ~smoser/cloud-init:feature/redhat-spec-improvements into cloud-init:master
Status: | Merged |
---|---|
Approved by: | Scott Moser |
Approved revision: | 8ecb7ad780754f4877d4f03e7b8d51e1d94340dd |
Merge reported by: | Scott Moser |
Merged at revision: | 914822a765007be7e17539e456b3e6ff12b19442 |
Proposed branch: | ~smoser/cloud-init:feature/redhat-spec-improvements |
Merge into: | cloud-init:master |
Diff against target: |
230 lines (+65/-44) 4 files modified
cloudinit/distros/__init__.py (+1/-1) cloudinit/distros/centos.py (+12/-0) packages/redhat/cloud-init.spec.in (+52/-40) requirements.txt (+0/-3) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ryan Harper | Approve | ||
Server Team CI bot | continuous-integration | Approve | |
Review via email: mp+325311@code.launchpad.net |
Commit message
rhel/centos spec cleanups.
Many changes here to get us able to build rpms on CentOS 5 or 6 and RHEL.
* add 'Requires' as 'BuildRequires' also.
This allows us to run cloud-init tools in the build environment, and
also will allow us to run tests in the build process.
* build for both systemd and upstart (centos 5) init systems.
* drop argparse from the requirements.
On any system other than python 2.6, having a 'requirements' that mentions
argparse just causes problems. Instead we add that Requires to the spec
directly.
* Add 'centos' as a variant
**FIXME**: This needs to add to cloudinit/util.py 'system_info' that is pulled in from the cloud-cfg-tmpl branch.
Adding the variant means we can use the 'centos' user as default on centos
rather than a 'fedora' or 'rhel'.
Do we actually need the centos variant now?