Code review comment for ~smoser/cloud-init:bug/before-fsck

Thanks Scott -- Agreed, I mostly just want to see the links back and forth.

On Tue, Jul 11, 2017 at 9:05 AM, Scott Moser <email address hidden> wrote:

> David,
>
> Balint's work flow here is completely valid.
> He was reviewing https://code.launchpad.net/~smoser/cloud-init/+git/cloud-
> init/+merge/324191 and wanted to suggest a different path for fixes so he
> proposed a merge into that branch (~smoser/cloud-init:bug/before-fsck).
>
> I often do the same when I think its easier to just show code for what i
> mean than explaining in words the changes I'd like.
>
> The one thing I would suggest is that when that is done you should comment
> in the original merge proposal. something to the affect of:
> Hey, i thought of a different way to do this and worked up a merge
> proposal at http://.....
> --
> https://code.launchpad.net/~smoser/cloud-init/+git/cloud-
> init/+merge/324191
> You are subscribed to branch cloud-init:master.
>
> Launchpad-Message-Rationale: Subscriber
> Launchpad-Message-For: davidpbritton
> Launchpad-Notification-Type: code-review
> Launchpad-Branch: ~cloud-init-dev/cloud-init/+git/cloud-init:master
> Launchpad-Project: cloud-init
>

--
David Britton <email address hidden>