Code review comment for ~smb/ubuntu/+source/iproute2:ubuntu/eoan-devel

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

You'd not need to carry the old commits and then revert them.
Those can just be deleted, as combined they are a no-op.

Since this is functionally equivalent this is just an FYI.
You could as well squash them into "nothing" before the next rebase.
But since dropping them now just makes life easier down the road I'd recommend to do so.

The rest LGTM, do you have a PPA to build-test and test it ahead of an upload?

review: Needs Fixing

« Back to merge proposal