Code review comment for ~slyon/snappy-hwe-snaps/+git/network-manager:slyon/drop-vendorized-netplan

Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Thanks for this!

Thinking about netplan/libnetplan, is there any dependency on a newer core20 version added due to the changes in the NM netplan patch? If that is the case we would need an assumes also for core20.

For the removed "software-properties-common" build dep, there was a comment related to "package-repositories:". Does that mean that the comments at the beginning of snapcraft.yaml need to be removed too? I mean:

# Some packages might land in the ubuntu-image PPA for making their way
# into a Ubuntu Core base image and only later land in a LTS release.
# Enable ubuntu-image PPA once the --enable-experimental-package-repositories
# flag is not needed anymore
# package-repositories:
# - type: apt
# ppa: canonical-foundations/ubuntu-image

« Back to merge proposal