Merge lp:~slub.team/goobi-production/bug-1013622 into lp:goobi-production/1.7

Proposed by Ralf Claussnitzer
Status: Merged
Approved by: Ralf Claussnitzer
Approved revision: 73
Merged at revision: 73
Proposed branch: lp:~slub.team/goobi-production/bug-1013622
Merge into: lp:goobi-production/1.7
Diff against target: 29 lines (+1/-10)
1 file modified
build.xml (+1/-10)
To merge this branch: bzr merge lp:~slub.team/goobi-production/bug-1013622
Reviewer Review Type Date Requested Status
Henning Gerhardt Approve
Matthias Ronge Pending
zeutschel Pending
Review via email: mp+112591@code.launchpad.net

Description of the change

Changing <zipfileset> to <zipgroupfileset> deflates all dependend JARs and generates a big combined JAR file.

NOTE: This is probably violating licenses of the used libraries, especially if from Sun. Consider it a workaround.

To post a comment you must log in.
Revision history for this message
Henning Gerhardt (henning-gerhardt) wrote :

looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'build.xml'
--- build.xml 2012-05-09 15:19:19 +0000
+++ build.xml 2012-06-28 15:36:29 +0000
@@ -295,24 +295,15 @@
295295
296 <!-- Build standalone CLI jar -->296 <!-- Build standalone CLI jar -->
297 <target name="jar" depends="compile, copy-config">297 <target name="jar" depends="compile, copy-config">
298
299 <manifestclasspath property="manifest.classpath" jarfile="${build.dist.jar}">
300 <classpath>
301 <fileset dir="${lib.dir}" includes="*.jar"/>
302 </classpath>
303 </manifestclasspath>
304
305 <jar destfile="${build.dist.jar}">298 <jar destfile="${build.dist.jar}">
306 <fileset dir="${build.classes}" includes="**/*.class, log4j.properties, GoobiConfig.properties, hibernate.cfg.xml"/>299 <fileset dir="${build.classes}" includes="**/*.class, log4j.properties, GoobiConfig.properties, hibernate.cfg.xml"/>
307 <zipfileset dir="${lib.dir}" prefix="lib"/>300 <zipgroupfileset dir="${lib.dir}" includes="*.jar"/>
308
309 <manifest>301 <manifest>
310 <attribute name="Implementation-Title" value="${ant.project.name}"/>302 <attribute name="Implementation-Title" value="${ant.project.name}"/>
311 <attribute name="Implementation-Version" value="${build.dist.version}"/>303 <attribute name="Implementation-Version" value="${build.dist.version}"/>
312 <attribute name="Implementation-Vendor" value="${build.dist.vendor}"/>304 <attribute name="Implementation-Vendor" value="${build.dist.vendor}"/>
313 <attribute name="Implementation-URL" value="${build.dist.url}"/>305 <attribute name="Implementation-URL" value="${build.dist.url}"/>
314 <attribute name="Implementation-Build-Date" value="${TODAY_UK}"/>306 <attribute name="Implementation-Build-Date" value="${TODAY_UK}"/>
315 <attribute name="Class-Path" value=". ${manifest.classpath}"/>
316 <attribute name="Main-Class" value="org.goobi.production.cli.CommandLineInterface"/>307 <attribute name="Main-Class" value="org.goobi.production.cli.CommandLineInterface"/>
317 </manifest>308 </manifest>
318 </jar>309 </jar>

Subscribers

People subscribed via source and target branches

to all changes: