Code review comment for ~slingamn/ssh-import-id:norequests.release

Revision history for this message
Scott Moser (smoser) wrote :

@Robie,
Thanks for your time reviewing.
What kind of test do you want to see?

 I'd say the following:

   * ssh-import-id valid-user
   * ssh-import-id lp:valid-user
   * ssh-import-id gh:valid-user
   * ssh-import-id invalid-user
   * ssh-import-id lp:invalid-user
   * ssh-import-id gh:invalid-user
   * URL="http://localhost:9999/%s.pub" ssh-import-id valid-user
   * URL="http://localhost:9999/%s.pub" ssh-import-id invalid-user

In the URL cases, assume that URL has a 'valid-user.pub' and no 'invalid-user.pub'.

Clearly it'd be good to have these tests automated and in c-i.

@Shivaram,
Thanks for your effort with this.
Go ahead and push a removal of the 'import ssl'.

« Back to merge proposal