Merge lp:~sladen/unity-asset-pool/unity-asset-pool-icons-lp745555 into lp:unity-asset-pool

Proposed by Paul Sladen
Status: Merged
Merged at revision: 50
Proposed branch: lp:~sladen/unity-asset-pool/unity-asset-pool-icons-lp745555
Merge into: lp:unity-asset-pool
Diff against target: 42 lines (+11/-1)
1 file modified
unity-icon-theme/index.theme (+11/-1)
To merge this branch: bzr merge lp:~sladen/unity-asset-pool/unity-asset-pool-icons-lp745555
Reviewer Review Type Date Requested Status
Paul Sladen (community) Needs Resubmitting
Didier Roche-Tolomelli Pending
Review via email: mp+57307@code.launchpad.net

This proposal supersedes a proposal from 2011-04-11.

Description of the change

Glad the extra rename meta-data was useful rather than a delete/create :)

Resubmitting per-IRC since that's what's available.

Didrocks: I should note that in the massive-asset-dump there were 62 icons with no hint as to which ones actually needed replacing. If (in your opinion) the change between before and after is indistinguishable/imperceivable then there's a the opinion not to ship it on the basis that no "diff" of the priority changes was provided with the dump.

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote : Posted in a previous version of this proposal

renamed file 'unity-icon-theme/places/svg/group-mostused.svg' => 'unity-icon-theme/places/22/group-mostused.png'

All that will make a lot of changes in the places, change which should be coordinated and such.

Please, repropose a merge for the other contents (launcher/tile_arrow.png, panel/divider.png, unity-icon-theme/apps/48/workspace-switcher.png and unity-icon-theme/places/48/user-trash*) without those changes

review: Disapprove
51. By Paul Sladen

revert -r49 unity-icon-theme/places/svg/group-*.svg per IRC

Revision history for this message
Paul Sladen (sladen) :
review: Disapprove
Revision history for this message
Paul Sladen (sladen) wrote :

bzr revert -r49 unity-icon-theme/places/svg/group-*.svg per IRC

review: Needs Resubmitting
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote : Posted in a previous version of this proposal

ok, launchpad is laggy to refresh the merge, taking the branch, all looks good now :) thanks Paul!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'launcher/tile_arrow.png'
0Binary files launcher/tile_arrow.png 2010-08-16 11:51:34 +0000 and launcher/tile_arrow.png 2011-04-12 11:43:34 +0000 differ0Binary files launcher/tile_arrow.png 2010-08-16 11:51:34 +0000 and launcher/tile_arrow.png 2011-04-12 11:43:34 +0000 differ
=== modified file 'panel/divider.png'
1Binary files panel/divider.png 2010-09-13 14:53:28 +0000 and panel/divider.png 2011-04-12 11:43:34 +0000 differ1Binary files panel/divider.png 2010-09-13 14:53:28 +0000 and panel/divider.png 2011-04-12 11:43:34 +0000 differ
=== added directory 'unity-icon-theme/apps/48'
=== added file 'unity-icon-theme/apps/48/workspace-switcher.png'
2Binary files unity-icon-theme/apps/48/workspace-switcher.png 1970-01-01 00:00:00 +0000 and unity-icon-theme/apps/48/workspace-switcher.png 2011-04-12 11:43:34 +0000 differ2Binary files unity-icon-theme/apps/48/workspace-switcher.png 1970-01-01 00:00:00 +0000 and unity-icon-theme/apps/48/workspace-switcher.png 2011-04-12 11:43:34 +0000 differ
=== modified file 'unity-icon-theme/index.theme'
--- unity-icon-theme/index.theme 2010-08-31 13:32:29 +0000
+++ unity-icon-theme/index.theme 2011-04-12 11:43:34 +0000
@@ -6,7 +6,12 @@
6Example=directory-x-normal6Example=directory-x-normal
77
8#Directory list8#Directory list
9Directories=apps/128,places/22,search/16,web/489Directories=apps/48,apps/128,places/22,places/48,places/svg,search/16,web/48
10
11[apps/48]
12Size=48
13Context=Apps
14Type=Fixed
1015
11[apps/128]16[apps/128]
12Size=12817Size=128
@@ -23,6 +28,11 @@
23Context=Places28Context=Places
24Type=Scalable29Type=Scalable
2530
31[places/48]
32Size=48
33Context=Places
34Type=Fixed
35
26[search/16]36[search/16]
27Size=1637Size=16
28Context=Search38Context=Search
2939
=== added directory 'unity-icon-theme/places/48'
=== added file 'unity-icon-theme/places/48/user-trash-full.png'
30Binary files unity-icon-theme/places/48/user-trash-full.png 1970-01-01 00:00:00 +0000 and unity-icon-theme/places/48/user-trash-full.png 2011-04-12 11:43:34 +0000 differ40Binary files unity-icon-theme/places/48/user-trash-full.png 1970-01-01 00:00:00 +0000 and unity-icon-theme/places/48/user-trash-full.png 2011-04-12 11:43:34 +0000 differ
=== added file 'unity-icon-theme/places/48/user-trash.png'
31Binary files unity-icon-theme/places/48/user-trash.png 1970-01-01 00:00:00 +0000 and unity-icon-theme/places/48/user-trash.png 2011-04-12 11:43:34 +0000 differ41Binary files unity-icon-theme/places/48/user-trash.png 1970-01-01 00:00:00 +0000 and unity-icon-theme/places/48/user-trash.png 2011-04-12 11:43:34 +0000 differ

Subscribers

People subscribed via source and target branches

to all changes: