Code review comment for lp:~skinny.moey/drizzle/show_variables_582975

Revision history for this message
Monty Taylor (mordred) wrote :

Looks mostly good. However ...

opt_scheduler_default= (char*) "multi_thread";

Casting a static const char * to a char * is something I've been trying to get rid of in the tree in general. Is there a reason you needed to go away from from the const string here?

review: Needs Information

« Back to merge proposal